Open
Conversation
fjarri
force-pushed
the
error-derivation
branch
from
ffa12dc to
0763d32
Compare
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
==========================================
+ Coverage 47.49% 48.83% +1.34%
==========================================
Files 17 17
Lines 1017 989 -28
==========================================
Hits 483 483
+ Misses 534 506 -28
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the need of making separate
Displayimpls for errors. Would be nice to usethiserrorinstead, but it doesn't support no-std.Problems:
sourceand thus have a docstring. Annoying.sec1::Error, which is returned byEncodedPoint::from_bytes()) because of trait bounds not satisfied.#[derive(Snafu)] enum MyError { Something }implicitly addsSomethingSnafuto the namespace, which is supposed to be used with theResultExttrait.So I don't know. Would be nice to remove some boilerplate, but I don't love this crate. Leaving the PR in the suspended state for now.